Fix Flaky - TestFindFilePath #498
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Summary: The TestFindFilePath seems to have been failing for a long time, and has been disabled as a result. From what I could tell the majority of the failures were caused by line 107 of `common_test.go` Error: ``` mkdir /data/sandcastle/boxes/eden-trunk-hg-fbcode-fbsource/buck-out/v2/gen/fbcode/fec7e7876e628ce7/security/redteam/purple_team/ttpforge/pkg/blocks/__blocks_test__/temp_test_directory: file exists ``` https://www.internalfb.com/intern/testinfra/diagnostics/15762598732684907.281475092932540.1717744299/ https://www.internalfb.com/intern/testinfra/diagnostics/15762598732684907.281475092932540.1717744298/ etc... Modifying `os.Mkdir` to `os.MkdirAll` should prevent an error from being thrown in the event that this directory already exists on the system. Differential Revision: D58301576
|
This pull request was exported from Phabricator. Differential Revision: D58301576 |
|
This pull request has been merged in cdc8a84. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary:
The TestFindFilePath seems to have been failing for a long time, and has been disabled as a result.
From what I could tell the majority of the failures were caused by line 107 of
common_test.goError:
https://www.internalfb.com/intern/testinfra/diagnostics/15762598732684907.281475092932540.1717744299/
https://www.internalfb.com/intern/testinfra/diagnostics/15762598732684907.281475092932540.1717744298/
etc...
Modifying
os.Mkdirtoos.MkdirAllshould prevent an error from being thrown in the event that this directory already exists on the system.Differential Revision: D58301576